Monday, July 03, 2006 7:52 AM
Mickey Williams
Bad Design Decisions in TFS: XML passed as a string
I try not to whine too much on the blog, but I've been working on a side project that involves extending TFS eventing, and one of the first things I saw when I peeked under the covers was the definition of the notification web service method:
[WebMethod]
public void Notify(string eventXml, string tfsIdentityXml)
{
...
}
Now, not using WS-Eventing is certainly annoying, especially to those of us in the WS-* Breakfast Club, but the signature is downright embarrassing. Passing XML content as a string screams, "I'm really not sure I know what the hell I'm doing", and not in that cool punk-rock garage-band way. It's a key part of the extensibility plumbing. Could nobody have caught this in an SDR or something?